merge check indexation status and reindex all in one endpoint#448
Open
merge check indexation status and reindex all in one endpoint#448
Conversation
sBouzols
reviewed
Oct 13, 2023
sBouzols
reviewed
Oct 13, 2023
sBouzols
requested changes
Oct 13, 2023
|
Kudos, SonarCloud Quality Gate passed! |
sBouzols
approved these changes
Oct 17, 2023
Contributor
sBouzols
left a comment
sBouzols
left a comment
There was a problem hiding this comment.
Code Review OK
Tests OK (standard, with study-server stopped, with conversion-server stopped)
SlimaneAmar
reviewed
Oct 18, 2023
|
|
||
| @Transactional | ||
| public void reindexStudyIfNeeded(UUID studyUuid) { | ||
| StudyIndexationStatus status = getStudyIndexationStatus(studyUuid); |
Contributor
There was a problem hiding this comment.
Make private getStudyIndexationStatus
| @ApiResponse(responseCode = "200", description = "Study reindexed") | ||
| public ResponseEntity<Void> reindexStudy(@Parameter(description = "study uuid") @PathVariable("studyUuid") UUID studyUuid) { | ||
| studyService.reindexStudy(studyUuid); | ||
| @PostMapping(value = "/studies/{studyUuid}/reindex-if-needed") |
Contributor
There was a problem hiding this comment.
I think it might be better to keep the endpoint reindex-all to force reindexation ?
/studies/{studyUuid}/reindex-all?if-needed=true/false
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.